Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade index.ts #1035

Closed
wants to merge 1 commit into from
Closed

Conversation

Cherkaso8
Copy link

Added error processing in case the user cancels the request to connect the wallet:

Announce "let address: Address;" only once in front of the try block to avoid conflict

Added error processing in case the user cancels the request to connect the wallet:

Announce "let address: Address;" only once in front of the try block to avoid conflict
Copy link

height bot commented Dec 18, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: d4587de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 18, 2024

@Cherkaso8 is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

@cesarenaldi
Copy link
Member

@Cherkaso8 thank you for taking the time. But the examples serve the purpose of explaining Lens SDK specific features, not be 100% accurate on 3rd party aspects. There's many things we could have done to make the example bombproof (e.g., switch to network, add network, etc.) but it would add unnecessary noise and defeated the purpose of explaining something.

Going to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants